Switch from winapi to windows-sys #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LingMan
force-pushed
the
win
branch
2 times, most recently
from
1d87f08 to
0b3a2d7
Compare
The ecosystem is switching from winapi to the Microsoft-maintained windows-sys. Follow suit so depentents don't have to compile both. This raises the MSRV to 1.48.
|
Thanks! If you have the time, I'd appreciate having rustfmt enforced in CI as well. Then we can prevent regressions in formatting. |
|
Sure, I wanted to give CI some love anyway. |
|
@lambda-fairy What are your plans on releasing a version with this PR included? Would like to see winapi gone in my builds :) |
|
@Unpublished Released. Thanks for waiting :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is a pure
cargo fmtrun to get a clean slate. The second commit is more interesting and switches fromwinapito thewindows-sys, which is maintained by Microsoft.The wider ecosystem appears to be switching. Let's follow suit so dependents don't have to compile both. At least in my dependency trees
errnois one of the last holdouts.This raises the MSRV to 1.48. For the last MSRV bump
capsandrustixwere considered.rustixalready depends onwindows-sysand is interested in having this change whilecapshas since dropped their dependency onerrno(both per lucab/caps-rs#79).I have ideas for a few more cleanups/minor fixes but they would collide with these changes, so it would be best to merge this first.